chore: remove tx hashes handling on int contract calls #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the tx_hash handling of events, since it's always going to be the tx hash of the ContractCall transaction.
sborrazas
changed the title
thepiwo
reviewed
Dec 31, 2022
this isn't a breaking change, it's more of a removal of a tx_hash that was being handled internally throughout contract call events which is always the same tx_hash as the actual contract call. this was very confusing, so on this PR I removed the tx_hash altogether. but this is only done internally, there's no change in the endpoints |
thepiwo
approved these changes
Jan 2, 2023
jyeshe
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.