Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doppler: CleanUp #212

Open
hornig opened this issue Oct 20, 2020 · 3 comments
Open

Doppler: CleanUp #212

hornig opened this issue Oct 20, 2020 · 3 comments

Comments

@hornig
Copy link
Collaborator

hornig commented Oct 20, 2020

Taking a look into the new Doppler Folder, I would like to take a chance to ask for cleanup.

Are these files needed?

The full archive folder?
https://github.com/aerospaceresearch/orbitdeterminator/tree/master/orbitdeterminator/doppler/archive

This temp File? It just does some prints.
https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/doppler/temp.py

@Himanshu12145
Copy link

Greetings @hornig I would love to contribute to this problem please guide me through out this as this is my first contribution in aero-space project . I need to to know what actually am I supposed to do ?

@rahulv1999
Copy link

@hornig the temp.py I don't think is needed now its purpose I guess was to check the import of astropy package but we can include that in a test file, and the archive folder contains 2 test so that will be needed.

@hornig
Copy link
Collaborator Author

hornig commented Mar 25, 2021

@apak-00 , what do you think? :)
can we somehow "clean" up yout old folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants