Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traceparent header not forwarded to browser container #1260

Open
davidamir10 opened this issue Aug 25, 2022 · 3 comments
Open

traceparent header not forwarded to browser container #1260

davidamir10 opened this issue Aug 25, 2022 · 3 comments

Comments

@davidamir10
Copy link

Hello,
we are using opentelemetry and instrumenting urllib3 in pytest. Each request on the remote web-driver has traceparent header
https://www.w3.org/TR/trace-context/#traceparent-header-field-values
It seems that selenoid is not forwarding the header to the browser, so we are not able to see the traces coming from backend.

Can you please include the traceparent header (if exist) in the request to the browser?

@davidamir10 davidamir10 changed the title traceparent header not forwarded to browser images traceparent header not forwarded to browser container Aug 25, 2022
@vania-pooh
Copy link
Member

@davidamir10 Selenoid is reverse proxying all requests except new session request. Could you please provide an exact HTTP request header that you want to reverse proxy?

@davidamir10
Copy link
Author

davidamir10 commented Aug 26, 2022

@vania-pooh, thanks for quick response!
here's an example traceparent header:
traceparent: 00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01

the header key is traceparent

@vania-pooh vania-pooh added this to the 1.10.9 milestone Aug 26, 2022
@vania-pooh vania-pooh modified the milestones: 1.10.10, 1.10.11 Feb 14, 2023
@vania-pooh
Copy link
Member

Need to proxy Tracestate and Traceparent headers.

@vania-pooh vania-pooh modified the milestones: 1.10.12, 1.11.0 May 25, 2023
@vania-pooh vania-pooh modified the milestones: 1.11.0, 1.11.1 Jul 25, 2023
@vania-pooh vania-pooh removed this from the 1.11.2 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants