Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multilingual solution with I18 #8

Open
aermin opened this issue Feb 18, 2019 · 5 comments
Open

multilingual solution with I18 #8

aermin opened this issue Feb 18, 2019 · 5 comments

Comments

@aermin
Copy link
Owner

aermin commented Feb 18, 2019

之前的Auth系统是login或者register的时候通过用户输入的userName来判断,后来支持了github auth 登录,造成有可能出现多个相同的userName,这样之前的userName Auth 登录会有bug,所以目前采用的解决方案是将userName Auth 和 Github Auth 分离开,userName Auth登录的时候将查找非github用户(github_id IS NULL)的账户密码进行校验

=>

image

@webrtcsrs
Copy link

Hello Aermin, very nice project is it possible to have comments in English? Otherwise it becomes impossible to read everything.

@aermin
Copy link
Owner Author

aermin commented Feb 22, 2019

Hello Aermin, very nice project is it possible to have comments in English? Otherwise it becomes impossible to read everything.

Hi, Dani. Sorry to reply so late. These comments are just some development logs. I will write a blog in English this weekend which includes this development logs. Thank you for your attention.

@aermin
Copy link
Owner Author

aermin commented Feb 22, 2019

@Dani2003 Pls tell me if you have any problem or suggestion in using this project.

@ciaoamigo
Copy link

Your project is beautiful. Have you thought about a multilingual solution with I18?

@aermin
Copy link
Owner Author

aermin commented Feb 27, 2019

Your project is beautiful. Have you thought about a multilingual solution with I18?

Thank you. The multilingual solution with I18 is in my todo list. But there are some more important features as well for this product, such as lazy loading in chat. But I think I can make it done in the next half a month(Sorry, I am busy in work these days 😞 ).

@aermin aermin changed the title Auth 系统设计 multilingual solution with I18 Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants