Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this be a versioned reference? #179

Open
rofrankel opened this issue Apr 26, 2024 · 3 comments
Open

Should this be a versioned reference? #179

rofrankel opened this issue Apr 26, 2024 · 3 comments

Comments

@rofrankel
Copy link
Collaborator

          Should this be a versioned reference?

Originally posted by @gibson042 in #173 (comment)

@rofrankel rofrankel mentioned this issue Apr 26, 2024
11 tasks
@rofrankel
Copy link
Collaborator Author

I don't know if it makes sense for aep.dev/filtering to point to a specific version of the CEL spec - to me, that would imply that the AEPs have opinions about specific details of CEL versions, and I'm not sure that they should.

I guess CEL 2.0 could come out with breaking changes? But if that happens, then A) hopefully it doesn't break the non-versioned link; and B) I'm not sure we want to tell people to stay on CEL 1.0 by default forever anyway.

WDYT?

@gibson042
Copy link
Contributor

No matter what, I think each API must document specifics of what it supports, which would need to include this detail in the event of a backwards-incompatible CEL 2 (and if the API supports both versions, then we'd be looking at adding something like a filterLanguage field for conveying the interpretation of filter). But since language restrictions are already permitted anyway, cross-API portability is not guaranteed so I think I agree that the AEP-level references do not need to be versioned.

@gibson042
Copy link
Contributor

So AFAICT, no changes are needed at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants