Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/647 #649

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Issue/647 #649

merged 4 commits into from
Mar 7, 2024

Conversation

fongsean
Copy link
Collaborator

@fongsean fongsean commented Mar 7, 2024

Resolves #639 and #640.

Attachment component is built from scratch.
Reference type uses the string component currently, need to fix in the future.
Quantity type uses the decimal component currently, need to fix in the future.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.83%. Comparing base (e6007a0) to head (488ed7b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   70.83%   70.83%           
=======================================
  Files           1        1           
  Lines         120      120           
  Branches       40       40           
=======================================
  Hits           85       85           
  Misses         32       32           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fongsean fongsean merged commit e6c45d9 into main Mar 7, 2024
5 of 7 checks passed
@fongsean fongsean deleted the issue/647 branch March 7, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build reference and quantity components
1 participant