Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Cloud Marketplace example Notebooks to include logistic regression covariates #192

Open
BauerLab opened this issue Feb 22, 2021 · 1 comment
Labels
critical enhancement Things we need to add as soon as possible
Projects

Comments

@BauerLab
Copy link
Contributor

No description provided.

@BauerLab BauerLab added the critical enhancement Things we need to add as soon as possible label Feb 22, 2021
@piotrszul piotrszul added this to To do in Release 0.4 via automation Mar 1, 2021
@piotrszul piotrszul added this to To do in Maintenance Mar 4, 2021
@piotrszul
Copy link
Collaborator

@BauerLab as far as I can tell they are already included in the example notebook see: https://bitbucket.csiro.au/users/hos076/repos/variantspark-aws/browse/data/monitor-ami/notebook/VariantSpark_example.ipynb
(or : https://variantspark-marketplace-resources.s3.amazonaws.com/static/public/example_notebook.html)

covariates = [mt.pheno.isFemale, mt.pcs[0], mt.pcs[1]]

result = hl.logistic_regression_rows(test ='wald', 
                                          y=mt.pheno.isCase,
                                          x=mt.GT.n_alt_alleles(),
                                          covariates=covariates)

Also as the code for AWS deployment is managed in different repository I think it would be better to manage the related issue somewhere else, unless they do require changes in the core variant spark.

@piotrszul piotrszul removed this from To do in Release 0.4 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical enhancement Things we need to add as soon as possible
Projects
Development

No branches or pull requests

2 participants