Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Link DM Screen to Character Sheet preview #2121

Open
4 tasks
jtmonroe opened this issue Jul 14, 2022 · 2 comments
Open
4 tasks

Feature Request: Link DM Screen to Character Sheet preview #2121

jtmonroe opened this issue Jul 14, 2022 · 2 comments

Comments

@jtmonroe
Copy link

jtmonroe commented Jul 14, 2022

Module(s) Effected

Party
Share

Proposed Behavior

When the DM selects a character in the party tab, provide the option to see the full character sheet preview generated by the share feature.

Actual Behavior

DM has to manage both a shared link and a party member which makes life more difficult.

Steps to reproduce (if any)

  • Add a character to a party
  • As the DM, attempt to look at the characters in the party
  • DM is left with very few details

Tasks to complete (if multiple)

  • Hyperlink the Character div to a sheet preview
@jtmonroe
Copy link
Author

jtmonroe commented Jul 15, 2022

This may actually be a bug report. Looking at the HTML on the page, it shows

<a role="button" tabindex="0" class="statsPopover" data-bind="popover: {
              placement: 'bottom',
              content: $component.popoverHtml(),
            }" data-original-title="" title="">
            <img class="img-circle center-block" data-bind="
                css: {
                  'patron-circle': player.isActivePatron,
                  [player.canonicalPatreonTier]: player.isActivePatron,
                },
                attr: {
                  src: player.imageUrl || 'https://www.gravatar.com/avatar/{}?d=mm',
                  height: 80,
                  width: 80,
                  alt: player.isActivePatron ? `${player.name} is an active patron.` : '',
                },
              " src="https://i.pinimg.com/564x/1b/fd/47/1bfd471283019b8f770c5d074cd90f93.jpg" height="80" width="80" alt="">
          </a>

The name statsPopover suggests to me that there ought to be some link to stats, but it is not working.

@jtmonroe
Copy link
Author

After further investigation, I believe this is an error. Whenever I press the <a></a> frame that I showed above, an error comes into the console which reads

WebSocket connection to 'wss://app.adventurerscodex.com/api/live/c4fe8f62-c90b-46dc-982f-09b654a1fcc3?bearer=SmyHXZ5gf1SR1wDoWahv1G0MKmJFD2' failed: 
setupWS @ vendors~main.8135b973d88dcf1634af.js?e36db46343a03a2c04c5:2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant