Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind leftarrow/rightarrow from nextplayer/prevplayer #318

Closed
nthnwllms opened this issue Apr 14, 2020 · 7 comments
Closed

Unbind leftarrow/rightarrow from nextplayer/prevplayer #318

nthnwllms opened this issue Apr 14, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@nthnwllms
Copy link

It seems that since Panorama UI release, leftarrow and rightarrow are bound to switch to next player and previous player. Something that might be useful to look into since 99% of time spent using HLAE is in a replay and arrow keys are pretty useful

mirv_fix unbind_spectator_arrowkeys?

@nthnwllms nthnwllms added the enhancement New feature or request label Apr 14, 2020
@dtugend
Copy link
Member

dtugend commented Apr 18, 2020

would
mirv_bind key "commands"
be acceptable instead?

@nthnwllms
Copy link
Author

Whatever you think makes the most sense. I wouldn't mind using mirv_bind key for the arrow keys. Does it serve a purpose other than overriding those valve default bindings?

@dtugend
Copy link
Member

dtugend commented Apr 22, 2020

It could serve other purposes, e.g. allowing to rebind mirv_input and other stuff if designed properly, but the main purpose would be to over-come forced CS:GO bindings.

@nthnwllms
Copy link
Author

That makes a lot of sense and sounds like a good solution. I like this idea :)

@dtugend dtugend added this to the v3.0 milestone Apr 28, 2020
@dtugend dtugend modified the milestones: v3.0, v3.1 Aug 24, 2021
@dtugend dtugend removed this from the v3.2 milestone Dec 18, 2021
@dtugend dtugend added this to the v3 milestone Oct 9, 2022
@dtugend
Copy link
Member

dtugend commented Mar 8, 2024

@nthnwllms Is this problem still sort of in CS2, or we can close this issue?

@nthnwllms
Copy link
Author

nthnwllms commented Mar 8, 2024

Just tested and the issue has become more weird now...

The issue only occurs if the key is bound. If leftarrow and rightarrow are left unbound, it does not swap players. When I bind them to a command (in my test, I created a bind to toggle the spectator xray on/off), only then does it start swapping players, but also inputs my command. Unbind the key and it stops swapping players.

To reproduce...

  1. Load a replay
  2. Use console unbind leftarrow unbind rightarrow - Now they should not switch players when in first person mode
  3. Use console to bind leftarrow slot1 - You will see that left arrow now switches between players in first person mode

Up to you and other users if this is important and worth the effort. Like I mentioned to you personally, I don't work on CS stuff at the moment, but I do think arrow keys are nice to be able to use with HLAE.

@dtugend dtugend removed this from the v3 milestone May 13, 2024
@dtugend
Copy link
Member

dtugend commented May 19, 2024

Hi. Thank you for your suggestion. The implementation of this feature in a reasonable time-frame is currently not realistic for me. After considering that together with issue #896 I am closing this request as not planned for now, since it would block other things I would like to still get done before that. Sorry for the copy pasta.

@dtugend dtugend closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants