Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multilanguage and installation path with different languages #198

Closed
3 of 6 tasks
Purple-CSGO opened this issue Jun 24, 2019 · 10 comments
Closed
3 of 6 tasks
Labels
enhancement New feature or request

Comments

@Purple-CSGO
Copy link
Member

Purple-CSGO commented Jun 24, 2019

Now hlae does not support multi language well enough. Errors occurs if hlae is installed in a path with other languages. It really confuses some new hlae users whose native language isn't English.


I know a man who has worked on this and succeeded in translating&replacing strings that appear in GUI and Error messages in console. However, it requires lots of work and repeated work after each time a new version is released.


I don't know how to work with it. Maybe adding support for .xml files? Add a language folder then hlae program reads different xml files e.g. hlae/language/en_US.xml ./zh_CN.xml etc to display different languages, and then add language in main GUI?


That's only a suggestion. It will not take too long since this man has translated a lot of words. Maybe after some time of varification, these xml files can be added officially into the project.


Edit by @dtugend:

  • Make Installer to solve the path non-latin1 characters problem
  • Make Installer translatable
  • Make C# parts of HLAE GUI translatable
  • Make C++/CLI parts translatable or port them ^1
  • Make AfxHookSource translatable ^1
  • Make AfxHookGoldSrc translatable ^1

^1 depends on #317

@Purple-CSGO Purple-CSGO added the enhancement New feature or request label Jun 24, 2019
@dtugend
Copy link
Member

dtugend commented Jun 24, 2019

The problem with the install location can only be solved with an installer. While HLAE has an own bug related to that, the main problem is that these folders can not be mounted into CS:GO, see #65.

I will look into multi language support.
Not sure if it will be XML files, might also be gettext based or similar.

@dtugend
Copy link
Member

dtugend commented Aug 2, 2019

So far only the new installer can be localized:

But if you or someone else already want to contribute a translation, please have a look at it.

@dtugend dtugend added this to the v3.0 milestone Sep 25, 2019
@cherinyy
Copy link

cherinyy commented Jul 5, 2020

Hi @dtugend,

For Chinese, considering political factors, I hope that zh-Hans and zh-Hant can be used instead of zh-CN and zh-TW.

But I don't know how the program will handle the language setting.

What I have noticed so far:

zh-Hans:

zh-CN
zh-SG
zh-Hans-HK
zh-Hans-TW
...

zh-Hant:

zh-TW
zh-HK
zh-Hant-CN
zh-Hant-SG
...

@dtugend
Copy link
Member

dtugend commented Jul 5, 2020

I understand that things are complicated and to be honest I am not that well informed about the situation in Asia.

Those are international programming conventions / standards for naming them internally in the program: https://en.wikipedia.org/wiki/Language_localisation
It think pretty much all of Linux / GNU GetText uses the same internal codes.

It is up to the translators to translate the language codes politically correct into their own locale and I think this was already done here: https://l10n.advancedfx.org/zh-CN/l10n/all-resources/?search=zh-CN&string=279 - it says 中文(简体)which seems to mean Chinese Simplified.

What could be improved though is the labeling on the official support site: https://www.advancedfx.org/support/
Would changing it to 中文(简体)do?
Are there other similar places that can be improved?

I am not sure if changing the locale files and folder names installed on disk is a good idea, especially for the installer, it would make the code sort of awkward, if it works well at all.

@cherinyy
Copy link

cherinyy commented Jul 5, 2020

I understand that things are complicated and to be honest I am not that well informed about the situation in Asia.

Those are international programming conventions / standards for naming them internally in the program: https://en.wikipedia.org/wiki/Language_localisation
It think pretty much all of Linux / GNU GetText uses the same internal codes.

It is up to the translators to translate the language codes politically correct into their own locale and I think this was already done here: https://l10n.advancedfx.org/zh-CN/l10n/all-resources/?search=zh-CN&string=279 - it says 中文(简体)which seems to mean Chinese Simplified.

What could be improved though is the labeling on the official support site: https://www.advancedfx.org/support/
Would changing it to 中文(简体)do?
Are there other similar places that can be improved?

I am not sure if changing the locale files and folder names installed on disk is a good idea, especially for the installer, it would make the code sort of awkward, if it works well at all.

Yes, 中文(简体) means Chinese (Simplified).

So, this is the confusing place: zh-CN is strictly Chinese (China), Chinese: 中文(中国).

中文(简体) or Chinese (Simplified) corresponds to zh-Hans.

In the actual translation process, in order to avoid the influence of political factors, zh-CN will be marked as zh-Hans for translation.

If correcting this has a negative impact on the operation of the program or increases the workload, then keep the status quo. But I personally think that this is "not rigorous" in translation.

@dtugend
Copy link
Member

dtugend commented Jul 5, 2020

Do you mean the label in English for the hlae.site website is wrong and should be zh-Hans (?) instead or did I misunderstand?
What should it be in zh-CN files?
What does @Purple-CSGO think?

@Purple-CSGO
Copy link
Member Author

I'm not tranlating these words excactly the same. Just to have the same mean. And I don't think it's worthy to focus on these little things. It's not gonna related to politcal stuff for the current translation, cuz CN / TW stands for countries or areas. If you still think it's not 100% correct, then go ahead and push your translation

@Purple-CSGO
Copy link
Member Author

Do you mean the label in English for the hlae.site website is wrong and should be zh-Hans (?) instead or did I misunderstand?
What should it be in zh-CN files?
What does @Purple-CSGO think?

translation for hlae.site is correct, cuz we name it....

@cherinyy
Copy link

cherinyy commented Jul 5, 2020

Do you mean the label in English for the hlae.site website is wrong and should be zh-Hans (?) instead or did I misunderstand?
What should it be in zh-CN files?
What does @Purple-CSGO think?

No, I don’t mean that.
Please ignore what I said, this is a complicated question.
For now, just leave it as it is.

I am sorry for the confusion I caused.

@dtugend dtugend modified the milestones: v3.0, v3.1 Sep 18, 2021
@dtugend dtugend removed this from the v3.1 milestone Dec 18, 2021
@dtugend dtugend added this to the v3 milestone Oct 9, 2022
@dtugend dtugend removed this from the v3 milestone May 13, 2024
@dtugend
Copy link
Member

dtugend commented May 19, 2024

Hi. Thank you for your suggestion. The implementation of this feature in a reasonable time-frame is currently not realistic for me. After considering that together with issue #896 I am closing this request as not planned for now, since it would block other things I would like to still get done before that. Sorry for the copy pasta.

@dtugend dtugend closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants