-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't remove/change white background when new image is loaded #135
Comments
@Shuky, hello! Are you aware, that the image changing will reset the coordinates and visible area? I assume that it's the next issue, that you will encounter. |
@Norserium hi! For now I actually hacked a version seems like it did the trick |
Just for curiosity, does the setting of |
Hi folks, I am encountering the same issue (my use-case is the same - I am changing saturation etc - i.e. implementing a more feature-complete image editor based on this great component). The white background issue goes away if you set transition: none styles for background and foreground (as far as I can tell after a quick investigation, there is no idiomatic way to do this for now, so external css is one option), but the image keeps disappearing during reloading even if you remove the whitening transition with css and transitionTime=0. What would be the best way to apply such alterations to the image without resetting the coordinates/visible area etc? And thank you for this awesome library, it is the best of the kind for sure, great work. |
@trpx, hello!
What do you mean by "pixel-manipulating function"? |
@trpx, @Shuky, I agree that the swapping image procedure should be changed, because it's obviously too rigid now. You can't affect transitions. You can't preserve coordinates, visible area or image transforms. I do agree, but I'm not sure that I have spare time to redesign this complicated aspect of the library right now. It's the bad news. But I have good news at last. There is the nice workaround that can be used to smoothly change image without any side effects. Take a look. |
same problem here... any solution? |
@bgomes90, there is the workaround only now. I suppose that the regular solution will be available in the next major release on the analogy of react-advanced-cropper method: cropper.setImage(image); |
this workaround doesnt work =/ |
@bgomes90, then it's not the issue at all, especially, not this issue. Just change the cropper and stencil background. Look at the example. |
@Norserium it work when load, but not when crop |
@bgomes90, if you need to preserve the transparency just set the If it doesn't fit to you, you can set the canvas fill color (example). |
@Shuky, @trpx, just for your information. I assume that in the next major release it will be implemented in this manner. Any feedback is appreciated. |
Fantastic library, but the cropper has a stall when switching between images.
Even if the fade in animation is removed, once a new image is uploaded the canvas is immediately cleared and a white background appears when loading a new image.
I'm currently adding effects to the existing image (contrast, saturation, etc.) and would love to be able to make the transition smoother when I switch the cropper src image.
This can be solved be either:
The text was updated successfully, but these errors were encountered: