Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-blocking implementation #12

Open
langemeijer opened this issue Nov 11, 2015 · 2 comments
Open

non-blocking implementation #12

langemeijer opened this issue Nov 11, 2015 · 2 comments

Comments

@langemeijer
Copy link

The current implementation is using a blocking socket stream implementation.

Would you accept a non-blocking implementation in your project?
Do you have any criteria that I should meet for my contribution to be accepted?

@gordalina
Copy link

This project is not actively maintained, would be great for @adoy to let someone else maintain it so it can grow further.
If you plan on forking it, let me know, i may contribute.

@langemeijer
Copy link
Author

I think I'm a casual tourist passing by and will be improving the code as I pass along. I have no interest in maintaining it. I will have a working project within one or two weeks, and will probably never look at the fastcgi client code again unless something breaks down.

I'm building something like a scheduled job server. Until now we have a few servers that run jobs as cli scripts, but to take advantage of opcode caching we are changing to fpm.

I have a master process that commandeers fpm servers when jobs are ran. This master process will use a non-blocking version of the PHP-FastCGI-Client spawning a lot of requests per server over one client connection.

The non-blocking socket implementation is required to fit into the architecture of the already existing code for the master process.

If my goals match adoys' I can do the coding, prepare nice pull requests and do the discussions on why I choose to do stuff. I will do the coding anyway, and it will be in my github account.

On Wed, Nov 11, 2015 at 9:41 PM, Samuel Gordalina
notifications@github.com wrote:

This project is not actively maintained, would be great for @adoy to let someone else maintain it so it can grow further.

If you plan on forking it, let me know, i may contribute.

Reply to this email directly or view it on GitHub:
#12 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants