Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention for build downloads is YYYYDDMM not YYYYMMDD #259

Closed
lumpfish opened this issue Mar 13, 2018 · 7 comments
Closed

Naming convention for build downloads is YYYYDDMM not YYYYMMDD #259

lumpfish opened this issue Mar 13, 2018 · 7 comments
Assignees
Labels
bug Issues that are problems in the code as reported by the community

Comments

@lumpfish
Copy link
Contributor

The date part of the JDK download binaries is in YYYYDDMM format rather that the more usual YYYYMMDD.

So OpenJDK8-OPENJ9_x64_Linux_20180203.tar.gz is the build of the 2nd March and OpenJDK8-OPENJ9_x64_Linux_20181203.tar.gz is the build of the 12th March.

Is that intentional? If so, what was the reasoning behind it?

@karianna karianna added the bug Issues that are problems in the code as reported by the community label Mar 13, 2018
@karianna
Copy link
Contributor

Not intentional - I'd actually prefer a clearer DDMMYYYY format although YYYYMMDD is also acceptable.

@karianna karianna added this to Backlog in temurin-build Mar 13, 2018
@io7m
Copy link

io7m commented Mar 13, 2018

YYYYMMDD has the advantage of being lexicographically ordered. Sort strings of that format in ascending lexicographical order and you also get them in ascending chronological order for free.

@karianna
Copy link
Contributor

Fair point

@cstroe
Copy link

cstroe commented Aug 25, 2018

Looks like this should be fixed by #450 ?

@keithc-ca
Copy link
Contributor

This was fixed earlier, but the build flow has changed dramatically and I'm not sure where the source of the YYYYDDMM pattern is (#450 is targeted to a branch that isn't (yet?) being used as far as I can tell).

@sophia-guo
Copy link
Contributor

sophia-guo commented Aug 29, 2018

This should only happen to SDK OpenJDK8_aarch64_Linux_***, as build job openjdk8_build_aarch64_linux is configured differently. https://ci.adoptopenjdk.net/job/openjdk8_build_aarch64_linux/configure . That is saying this build doesn't use build story from openjdk-build (though I don't know why). I've updated the execute shell to

readonly TIMESTAMP="$(date +'%Y%m%d%H%M')"
# hardcoded major version and platform (architecture and os)

Which should solve this problem.
Ideally should set job parameter TIMESTAMP.

@sophia-guo
Copy link
Contributor

sophia-guo commented Aug 30, 2018

Today's aarch64 jdk8:OpenJDK8_aarch64_Linux_201808301146.tar.gz. Others look also good, good to close this for now. ( didn't realize I do not have permission, @karianna could you close it?)

temurin-build automation moved this from TODO to Done Aug 30, 2018
@karianna karianna removed this from the 2.x.x milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community
Projects
No open projects
temurin-build
  
Done
Development

No branches or pull requests

7 participants