Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shenandoah GC not available in 11.0.9 #2176

Closed
marko-asplund opened this issue Oct 24, 2020 · 10 comments · Fixed by #2177
Closed

Shenandoah GC not available in 11.0.9 #2176

marko-asplund opened this issue Oct 24, 2020 · 10 comments · Fixed by #2177
Assignees
Labels
bug Issues that are problems in the code as reported by the community
Milestone

Comments

@marko-asplund
Copy link

marko-asplund commented Oct 24, 2020

Platform: Linux

Architecture: x86_64

Please describe the issue that you are having with our binaries and if possible how to recreate it.

The AdoptOpenJDK 11.0.9 build doesn't appear to include Shenandoah GC.
Is it supposed to include the GC?

According to OpenJDK wiki it should be in mainline builds:

In mainline OpenJDK 11u builds since 11.0.9.

Here's what happens when trying to enable the GC on v11.0.9:

~ % docker run -it openjdk:11-jre-buster

root@6e987dc384f8:/# java -version
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment 18.9 (build 11.0.9+11)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.9+11, mixed mode)

root@6e987dc384f8:/# java -XX:+UseShenandoahGC -Xlog:gc -version
Unrecognized VM option 'UseShenandoahGC'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
@marko-asplund
Copy link
Author

It seems to be available in the Zulu OpenJDK 11.0.9+11 build:

~ % java -XX:+UseShenandoahGC -Xlog:gc -version
[0.005s][info][gc] Heuristics ergonomically sets -XX:+ExplicitGCInvokesConcurrent
[0.005s][info][gc] Heuristics ergonomically sets -XX:+ShenandoahImplicitGCInvokesConcurrent
[0.005s][info][gc] Using Shenandoah
openjdk version "11.0.9" 2020-10-20 LTS
OpenJDK Runtime Environment Zulu11.43+21-CA (build 11.0.9+11-LTS)
OpenJDK 64-Bit Server VM Zulu11.43+21-CA (build 11.0.9+11-LTS, mixed mode)
[0.052s][info][gc] Cancelling GC: Stopping VM

@aahlenst
Copy link
Contributor

The AdoptOpenJDK 11.0.9 build doesn't appear to include Shenandoah GC.

Shit.

Is it supposed to include the GC?

Yes, see #2125.

Without any Docker in between:

jdk-11.0.9+11/bin/java -XX:+UseShenandoahGC -Xlog:gc -version
Unrecognized VM option 'UseShenandoahGC'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
root@bb000aee1f7d:/# jdk-11.0.9+11/bin/java -version
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.9+11, mixed mode)

@sxa sxa added the bug Issues that are problems in the code as reported by the community label Oct 24, 2020
@sxa sxa assigned sxa and aahlenst Oct 24, 2020
@sxa sxa added this to TODO in temurin-build via automation Oct 24, 2020
@sxa sxa added this to the October 2020 milestone Oct 24, 2020
@sxa
Copy link
Member

sxa commented Oct 24, 2020

Thank you for reporting this @marko-asplund 🥇

@marko-asplund
Copy link
Author

Thank you for reporting this @marko-asplund 🥇

Thank you for your work for the AdoptOpenJDK project! 🙇 👍

@sxa sxa closed this as completed in #2177 Oct 24, 2020
temurin-build automation moved this from TODO to Done Oct 24, 2020
@sxa
Copy link
Member

sxa commented Oct 24, 2020

Updated bulids in progress and they seem to work:

[sxa@sainz bin]$ ./java -XX:+UseShenandoahGC -Xlog:gc -version
[0.014s][info][gc] Heuristics ergonomically sets -XX:+ExplicitGCInvokesConcurrent
[0.014s][info][gc] Heuristics ergonomically sets -XX:+ShenandoahImplicitGCInvokesConcurrent
[0.017s][info][gc] Using Shenandoah
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.9+11, mixed mode)
[0.112s][info][gc] Cancelling GC: Stopping VM
[sxa@sainz bin]$ 

@sxa
Copy link
Member

sxa commented Oct 26, 2020

Shenandoah-enabled builds are up on the web site as jdk-11.0.9+11.1 for the relevant platforms

@marko-asplund
Copy link
Author

Awesome - thanks! 🚀 🙌 👍

@marko-asplund
Copy link
Author

@sxa Thanks again! 👍

Btw, are you guys also releasing the official adoptopenjdk docker images?
It would be great to get a adoptopenjdk:11-jre-hotspot variant with 11.0.9 and Shenandoah.

@aahlenst
Copy link
Contributor

We make those. Always takes more time because it requires collaboration with outside orgs. PR is there: docker-library/official-images#8953

@sxa
Copy link
Member

sxa commented Oct 27, 2020

Yep - there was a slight delay as some modifications had to be made to handle some docker platforms having a .1 release and not others, so they will definitely be made available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community
Projects
No open projects
temurin-build
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants