Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rendering library to be consistent with other vendors of OpenJDK #1119

Open
Mekadrom opened this issue Jun 10, 2019 · 8 comments
Open
Assignees
Labels
enhancement Issues that enhance the code or documentation of the repo in any way Marlin Marlin Rendering issues (jdk8)

Comments

@Mekadrom
Copy link

After a brief conversation with others in the AdoptOpenJDK slack, I decided to open a ticket with an example of the differences between AdoptOpenJDK's chosen rendering native library and those of other OpenJDK vendors.

image

Note: Yes, the AdoptOpenJDK title bar size is now consistent with the default Windows title bar size. However, I don't believe that this is supposed to be the case. The windows pictured use the same exact code and that code extends JDialog.

The solution for this would be to implement the same or a similar native rendering library to the other vendors of OpenJDK.

If I need to add anything to this issue tracker, please let me know. I have no experience with this sort of thing and I actually have no clue what this whole native rendering library thing means, I'm just parroting martijnverburg from slack.

@karianna karianna added this to TODO in temurin-build via automation Jun 11, 2019
@karianna karianna added this to the June 2019 milestone Jun 11, 2019
@karianna karianna added enhancement Issues that enhance the code or documentation of the repo in any way TSC-Agenda Issues that have been flagged as inclusions for a future TSC meeting labels Jun 11, 2019
@karianna
Copy link
Contributor

@karianna karianna modified the milestones: June 2019, July 2019 Jul 5, 2019
@gdams
Copy link
Member

gdams commented Jul 26, 2019

@Mekadrom what java version are you using? Is this a fonts issue or a rendering issue?

@gdams gdams added Waiting on OP Issues that are awaiting a response from the original author of the ticket and removed TSC-Agenda Issues that have been flagged as inclusions for a future TSC meeting labels Jul 26, 2019
@Mekadrom
Copy link
Author

@gdams This would be in 1.8u212b03, the change was noticed after upgrading from 1.8u181.

@bourgesl
Copy link

bourgesl commented Nov 2, 2019

I prepared patches to backport the Marlin renderer 0.9.1.3 (like jdk14) to OpenJDK8 (jdk8u-dev).
See https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-November/010549.html
See my github repo:
https://github.com/bourgesl/marlin-jdk8u
Enjoy FOSS Marlin renderer,
Laurent

@karianna karianna added the TSC-Agenda Issues that have been flagged as inclusions for a future TSC meeting label Nov 3, 2019
@karianna
Copy link
Contributor

karianna commented Nov 3, 2019

Needs discussing at @AdoptOpenJDK/tsc level

@karianna
Copy link
Contributor

https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-May/011635.html shows the progress of the patch that @bourgesl is working on. We'll effectively wait for that to land upstream.

@karianna karianna removed TSC-Agenda Issues that have been flagged as inclusions for a future TSC meeting Waiting on OP Issues that are awaiting a response from the original author of the ticket labels May 23, 2020
@karianna karianna moved this from TODO to In Progress in temurin-build May 23, 2020
@bourgesl
Copy link

bourgesl commented May 24, 2020

Status of Marlin renderer backport to jdk8u-dev:

  • partial integration in 8u252: DO NOT USE IN PRODUCTION = 9/21 patches integrated = 0.7.3.2 release (2016.02) = pre-jdk9 release
  • partial integration in 8u262 or 8u-dev: DO NOT USE IN PRODUCTION = 10/21 patches integrated = 0.7.3.3 release (2016.03) = pre-jdk9 release

See up-to-date status:
https://github.com/bourgesl/marlin-jdk8u/blob/master/README.md

@karianna
Copy link
Contributor

Status of Marlin renderer backport to jdk8u-dev:

  • partial integration in 8u252: DO NOT USE IN PRODUCTION = 9/21 patches integrated = 0.7.3.2 release (june 2015) = pre-jdk9 release
  • partial integration in 8u262 or 8u-dev: DO NOT USE IN PRODUCTION = 10/21 patches integrated = 0.7.3.3 release (june 2015) = pre-jdk9 release

See up-to-date status:
https://github.com/bourgesl/marlin-jdk8u/blob/master/README.md

Thanks for your tireless work in getting this resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way Marlin Marlin Rendering issues (jdk8)
Projects
No open projects
temurin-build
  
In Progress
Development

No branches or pull requests

4 participants