Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop adding NODE_LABEL to build job parameters #53

Closed
wants to merge 1 commit into from
Closed

Stop adding NODE_LABEL to build job parameters #53

wants to merge 1 commit into from

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard self-assigned this Apr 3, 2023
sxa
sxa previously requested changes Apr 3, 2023
View reviewed changes
Copy link
Member

@sxa sxa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change title of the commit to NODE_LABEL (i.e. remove the extra L

@karianna karianna changed the title Stop adding NODEL_LABEL to build job parameters Stop adding NODE_LABEL to build job parameters Apr 4, 2023
@karianna
Copy link
Contributor

karianna commented Apr 4, 2023

Please change title of the commit to NODE_LABEL (i.e. remove the extra L

Changed it (FYI - you also have that power in the UI going forwards)

@karianna karianna requested a review from sxa April 4, 2023 07:10
@andrew-m-leonard
Stop adding NODE_LABEL to build job parameters
7c99ba4 
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@sxa
Copy link
Member

sxa commented Apr 4, 2023

Please change title of the commit to NODE_LABEL (i.e. remove the extra L

Changed it (FYI - you also have that power in the UI going forwards)

Fair point :-) I usually prefer to get the review first and do it myself, but in this case it was obvious and noncontroversial enough that Is probably have just done it. Thanks

@andrew-m-leonard andrew-m-leonard marked this pull request as draft April 4, 2023 12:04
@andrew-m-leonard
Copy link
Contributor Author

I reckon, this IS needed to schedule the build jobs, suspect we should be defining the job template with NODE_LABEL instead

@andrew-m-leonard
Copy link
Contributor Author

Close in favour of new PR #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@sxa sxa sxa approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Skipped parameter" warnings in jenkins server log
3 participants
@andrew-m-leonard @karianna @sxa