Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: move ADOPT_JENKINS_DEFAULTS_URL from caller than hardcoded in RepoHanlder #46

Open
zdtsw opened this issue Feb 2, 2023 · 0 comments
Open

Feature: move ADOPT_JENKINS_DEFAULTS_URL from caller than hardcoded in RepoHanlder #46

zdtsw opened this issue Feb 2, 2023 · 0 comments

Comments

@zdtsw
Copy link
Contributor

zdtsw commented Feb 2, 2023

https://github.com/adoptium/jenkins-helper/blob/master/src/common/RepoHandler.groovy#L24 is set to hardcoded with "master" branch
this will cause problem e.g for release cycle we want to checkout code from a release branch.

suggestion: to move away hardcoded value, and get it passed from caller (ci-jenkins-pipeline) with correct URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zdtsw