Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI-Installer: Text is cut off and not readable #732

Open
larsen0815 opened this issue Aug 4, 2023 · 9 comments
Open

MSI-Installer: Text is cut off and not readable #732

larsen0815 opened this issue Aug 4, 2023 · 9 comments
Labels
bug wix WiX installer

Comments

@larsen0815
Copy link

Please provide a brief summary of the bug

The help text for at least one element that can be installed is cut off (notice the "...").

Clipboard-1

Please provide steps to reproduce where possible

  • On Windows, start the installer for Temurin JDK 17
  • Continue until the page where it is possible to select elements to be installed
  • Select "JavaSoft (Oracle) registry keys"
  • See text on the right

Expected Results

Text should be short enough to be fully readable. Or better: Provide a link to a web page that has more information.

Actual Results

Text is cut off (to be precise: something is left out from the middle) and in this form makes no sense at all.

What Java Version are you using?

17

What is your operating system and platform?

No response

How did you install Java?

No response

Did it work before?

No response

Did you test with the latest update version?

No response

Did you test with other Java versions?

No response

Relevant log output

No response

@larsen0815 larsen0815 added the bug label Aug 4, 2023
@larsen0815
Copy link
Author

Using the program "textify", I got this. A little bit too long... Dialog is not resizable.

Overwrites the reg keys HKLM\Software\JavaSoft (Oracle). After uninstallation of Eclipse Temurin, Oracle Java running from PATH "C:\Program Files (x86)\Common Files\Oracle\Java\javapath" does not work. You need to reinstall it to recreate these registry keys

@karianna
Copy link
Contributor

karianna commented Aug 6, 2023

@gdams - one for the Wix 4 rewrite.

@gdams gdams transferred this issue from adoptium/adoptium-support Sep 5, 2023
@gdams gdams added the wix WiX installer label Sep 5, 2023
@douph1
Copy link
Contributor

douph1 commented Jan 3, 2024

As noted here

<!-- ! Description limité à 255 charactères -->

Description must be limited to 255 chars (spec that I found somewhere one time) .

This one on en-us is 258 chars after substituting {vendor_branding}) by "Eclipse Temurin"
In fr-fr around 256 with {vendor_branding}) replaced by "Eclipse Temurin"

I think I remember that the full text is show when the cursor go in top of the text.

Feel free to propose a shorter description for each language to fit into 255 chars

@adipiciu
Copy link
Contributor

adipiciu commented Jan 6, 2024

There is even a validation warning when building the msi:
warning SMOK1076 : ICE03: String overflow (greater than length permitted in column); Table: Feature, Column: Description, Key(s): FeatureOracleJavaSoft

image

@adipiciu
Copy link
Contributor

adipiciu commented Jan 6, 2024

I shortened the text under 255 length but it still doesn't show properly.
image

@adipiciu
Copy link
Contributor

adipiciu commented Jan 6, 2024

I propose to shorten the string, so it can fit and also to get rid of the validation warning.
If the string cannot fit, it adds ellipsis (...) and you won't understand anything anyway.

@douph1 what do you say?
image

@karianna
Copy link
Contributor

karianna commented Jan 7, 2024

I propose to shorten the string, so it can fit and also to get rid of the validation warning. If the string cannot fit, it adds ellipsis (...) and you won't understand anything anyway.

@douph1 what do you say? image

If you just remove Eclipse or Temurin, would that fit?

@adipiciu
Copy link
Contributor

adipiciu commented Jan 7, 2024

If you just remove Eclipse or Temurin, would that fit?

Eclipse Temurin is a variable {vendor_branding}. But even if I remove that, it still doesn't fit completely.

image

@adipiciu
Copy link
Contributor

adipiciu commented Jan 7, 2024

This is the maximum we can fit (159 characters)

image

adipiciu added a commit to adipiciu/adoptium_installer that referenced this issue Jan 9, 2024
…tium#732

Modify the feature description to fit in the installation window adoptium#732

Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
douph1 pushed a commit that referenced this issue Feb 12, 2024
…#791)

* Modify the feature description to fit in the installation window #732

---------
Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Philippe Doussot <45632394+douph1@users.noreply.github.com>
adipiciu added a commit to adipiciu/adoptium_installer that referenced this issue Feb 13, 2024
Modify the feature description to fit in the installation window adoptium#732

Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug wix WiX installer
Projects
None yet
Development

No branches or pull requests

5 participants