Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3rd party jar version in fname #541

Open
llxia opened this issue May 1, 2024 · 3 comments
Open

Remove 3rd party jar version in fname #541

llxia opened this issue May 1, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@llxia
Copy link
Contributor

llxia commented May 1, 2024

By keeping 3rd party jar version in fname, we need to update all the references when we upgrade the jar.

adoptium/aqa-tests#5270 ==> we need to update 15 reference lines

TODO:

@judovana
Copy link

judovana commented May 2, 2024

But that is ok, inst it? Lets change it and we are done, or do I miss anything?

@llxia
Copy link
Contributor Author

llxia commented May 2, 2024

This is an enhancement and does not block the merge of adoptium/aqa-tests#5270. Assuming this is what you are asking.

@llxia llxia added the enhancement New feature or request label May 2, 2024
@judovana
Copy link

judovana commented May 2, 2024

Oh that is clear. no reason to block that for sure. I'm just very slow to process how processes works.
As I was studying jcstresses - adoptium/aqa-tests#5261 - the individual steps may differ.
I had already mentioned : https://github.com/AdamBrousseau/TKG/blob/master/scripts/getDependencies.pl#L188 in adoptium/aqa-tests#5261 ; also It is clear if the jar is renamed, you have to change all fnames in https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml ... which I mentioned too. Or the name which is generated by https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/ will be adjusted to match what https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml needs. But that is up to discussion.

So there are now three issues, all about the same, and I'm not sure where to discuss what :)

@llxia llxia added the good first issue Good for newcomers label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants