Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the --openjdk_testrepo arg name in runAqaArgParse.py #295

Open
JeromeJu opened this issue Mar 11, 2022 · 2 comments
Open

Update the --openjdk_testrepo arg name in runAqaArgParse.py #295

JeromeJu opened this issue Mar 11, 2022 · 2 comments

Comments

@JeromeJu
Copy link
Contributor

JeromeJu commented Mar 11, 2022

Describe the bug
In the runAqaArgParse.py file, the --openjdk_testrepo arg name should be updated to --aqa-testrepo

Expected behavior
The run-aqa should later take in --aqa-testrepo arg

@JeromeJu JeromeJu changed the title Update the --openjdk_testrepo flag name in runAqaArgParse.py Update the --openjdk_testrepo arg name in runAqaArgParse.py Mar 11, 2022
@JeromeJu
Copy link
Contributor Author

JeromeJu commented Mar 15, 2022

Hi, I was investigating the effect of the one-liner in #298 via the [similar workflow] (https://github.com/JeromeJu/TKG/runs/5554345670?check_suite_focus=true) as #297 in my forked TKG repo PR.

TODO:

  • Use echos to check if in the correct repo
usage: run aqa [--help]
 [--sdk_resource {nightly,releases,customized,build-jdk} [{nightly,releases,customized,build-jdk} ...]]
 [--build_repo BUILD_REPO [BUILD_REPO ...]]
 [--customized_sdk_url CUSTOMIZED_SDK_URL [CUSTOMIZED_SDK_URL ...]]
 [--archive_extension {.zip,.tar,.7z} [{.zip,.tar,.7z} ...]]
 [--build_list {openjdk,functional,system,perf,external} [{openjdk,functional,system,perf,external} ...]]
 [--target TARGET [TARGET ...]]
 [--platform PLATFORM [PLATFORM ...]]
 [--jdk_version JDK_VERSION [JDK_VERSION ...]]
 [--jdk_impl {hotspot,openj9} [{hotspot,openj9} ...]]
 [--openjdk_testrepo OPENJDK_TESTREPO [OPENJDK_TESTREPO ...]]
 [--openj9_repo OPENJ9_REPO [OPENJ9_REPO ...]]
 [--tkg_repo TKG_REPO [TKG_REPO ...]]
 [--workflow_repo WORKFLOW_REPO [WORKFLOW_REPO ...]]
run aqa: error: unrecognized arguments: --aqatest_repo adoptium/aqa-tests:master

@JeromeJu
Copy link
Contributor Author

I checked again to make sure the checked out repo is the intended one. However, it still would not bring the correct output. As suggested from last meeting, shall we try merging this one-liner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant