Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-modifier to allow 4.x #550

Open
cah-brian-gantzler opened this issue Apr 18, 2023 · 6 comments
Open

Update ember-modifier to allow 4.x #550

cah-brian-gantzler opened this issue Apr 18, 2023 · 6 comments

Comments

@cah-brian-gantzler
Copy link

Please extend the range of ember modifier to use 3.x and 4.x

@tythewebguy
Copy link

I just wasted way too much time troubleshooting why ember-pikaday broke during my Ember 4 upgrade only to discover this fix has been committed to master but a new version has not been released. A version 4.0.1 would be really nice.

@cah-brian-gantzler
Copy link
Author

:) Pretty sure I asked already a couple times to have a new release. You said ember 4, but think you mean ember-modifier 4 and yes, waiting on the same thing.

@tythewebguy
Copy link

I'm in the process of upgrading our project to Ember 4 and yes, ember-pikaday broke because of the ember-modifier version. Your post here helped me figure out the problem and get it fixed. You saved me a lot frustration—THANK YOU!

@cloutierlp
Copy link

cloutierlp commented Oct 30, 2023

It would be a real pleasure to see this problem resolved. This seems to be already fixed in master. Is this just a release that needs to be done?

Can we help in any way?

@herzzanu
Copy link

Does the latest release fix this?

@cah-brian-gantzler
Copy link
Author

I believe it does.

However now the `@ember/test-helpers' could use its range extended to include 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants