Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fonts variable name #41

Open
adonyssantos opened this issue Mar 31, 2024 · 9 comments · Fixed by #46
Open

Update fonts variable name #41

adonyssantos opened this issue Mar 31, 2024 · 9 comments · Fixed by #46
Assignees
Labels
feature New feature or request good first issue Good for newcomers @palm-tree-css/core

Comments

@adonyssantos
Copy link
Owner

          This variable name is so generic. I think that we will create a more descriptive variable name, like `$font-body`, `$font-headings`, etc.

Originally posted by @adonyssantos in #40 (comment)

@joer9514 joer9514 self-assigned this Apr 1, 2024
@joer9514
Copy link
Collaborator

joer9514 commented Apr 1, 2024

why do you want a different font-family for body and headers?

@joer9514
Copy link
Collaborator

joer9514 commented Apr 1, 2024

I think variable names, directly related to properties like font-family, should have the same format: $font-family and keep this structure in all others.

@joer9514 joer9514 linked a pull request Apr 1, 2024 that will close this issue
@adonyssantos
Copy link
Owner Author

adonyssantos commented Apr 2, 2024

I think variable names, directly related to properties like font-family, should have the same format: $font-family and keep this structure in all others.

But you can have more than one font-family, so $font-family is so generic. For example: we can have fonts for the code blocks, headings, body, etc. Even if is the same font for all of them, it's a good practice to have different variables.

@Xansiety
Copy link

Xansiety commented Apr 2, 2024

I think variable names, directly related to properties like font-family, should have the same format: $font-family and keep this structure in all others.

But you can have more than one font-family, so $font-family is so generic. For example: we can have fonts for the code blocks, headings, body, etc. Even if is the same font for all of them, it's a good practice to have different variables.

Do you plan for each element to have a different typeface?

@adonyssantos
Copy link
Owner Author

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".

For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.

Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

@Xansiety
Copy link

Xansiety commented Apr 3, 2024

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".

For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.

Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

@joer9514 joer9514 removed their assignment Apr 3, 2024
@adonyssantos
Copy link
Owner Author

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".
For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.
Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

If you like you can work on it

@Xansiety
Copy link

Xansiety commented Apr 3, 2024

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".
For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.
Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

If you like you can work on it

Glad to contribute to the project!

@adonyssantos
Copy link
Owner Author

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".
For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.
Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

If you like you can work on it

Glad to contribute to the project!

Check our CONTRIBUTING.md and send the PR to the release/2.0.0 branch.

@adonyssantos adonyssantos added this to the Palm Tree 2.0.0 milestone Apr 12, 2024
@adonyssantos adonyssantos added feature New feature or request good first issue Good for newcomers labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers @palm-tree-css/core
Projects
Status: In progress
3 participants