Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shrinkwrap break new installation #317

Closed
mastito03 opened this issue Oct 14, 2016 · 4 comments
Closed

shrinkwrap break new installation #317

mastito03 opened this issue Oct 14, 2016 · 4 comments

Comments

@mastito03
Copy link
Contributor

i think shrinkwrap file unneeded in new installation as dependency not need to locked anyway

fsevents dependency on shrinkwrap file break new installation on linux and windows as this library can't be installed on that system.
@thetutlage
Copy link
Member

Agree! Also after reading this issue npm/npm#2679 shrinkwrap has some potential issues

Would you mind creating a PR for same?

@mastito03
Copy link
Contributor Author

adonisjs/adonis-app#36

@thetutlage
Copy link
Member

Merged. Closing

@lock
Copy link

lock bot commented Mar 11, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thetutlage @mastito03