Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_vpfiles() currently broken #648

Closed
peterdesmet opened this issue Dec 14, 2023 · 1 comment
Closed

download_vpfiles() currently broken #648

peterdesmet opened this issue Dec 14, 2023 · 1 comment
Labels

Comments

@peterdesmet
Copy link
Collaborator

peterdesmet commented Dec 14, 2023

https://lw-enram.s3-eu-west-1.amazonaws.com no longer exists, so the function download_vpfiles() is currently broken:

library(bioRad)
#> Welcome to bioRad version 0.7.3
#> using vol2birdR version 0.2.2.9043 (MistNet not installed)
download_vpfiles(radars = "bejab", date_min = "2023-10-10", date_max = "2023-10-11")
#> Downloading data from https://lw-enram.s3-eu-west-1.amazonaws.com
#> bejab202310.zip: http error 404

Created on 2023-12-14 with reprex v2.0.2

The function should be updated to read from the aloftdata bucket. See also #553 where it is suggested to rename the function to download_vpts_aloft() (with support for hdf5). I'm more in favour of having a generic download_files() function, which can be fed with a vector of URLs. That vector can be created with list_vpts_aloft().

@bart1
Copy link
Collaborator

bart1 commented Dec 14, 2023

Note that for that later route #647 also needs to be resolved

@adokter adokter mentioned this issue Jun 3, 2024
@adokter adokter closed this as completed in 5c378e8 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants