Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt read_vpts()and vpts object to VPTS CSV format #551

Open
12 tasks
peterdesmet opened this issue Mar 10, 2023 · 0 comments
Open
12 tasks

Adapt read_vpts()and vpts object to VPTS CSV format #551

peterdesmet opened this issue Mar 10, 2023 · 0 comments
Assignees
Labels
VPTS CSV Related to VPTS CSV format
Milestone

Comments

@peterdesmet
Copy link
Collaborator

peterdesmet commented Mar 10, 2023

Current functionality

Read a time series of vertical profiles (vpts) from file

read_vpts(
  file,
  radar,
  lat,
  lon,
  height,
  wavelength = "C"
)

Reason for change

  • VPTS CSV is now a standardized format for VPTS data. We need a function to read that data
  • It is intended to replace the "A text file containing the standard output (stdout) generated by vol2bird (or the package function calculate_vp)."

Questions

  • Should data be converted to VPTS object or remain a data frame? This depends on whether we want to keep vpts objects around or make those regular data frames. @adokter
  • VPTS objects have some conventions regarding column order and names. I think those should be adopted in VPTS (data frames).
  • Should it be possible to read from a URL in addition to single file path (supported by readr, see read_vpts(): support reading remote files #420)
  • Should we still support the legacy stdout objects? That requires keeping around all the parameters too.

Todo

  • Remove radar parameter. It is included in data as radar
  • Remove lat parameter. It is included in data as radar_latitude
  • Remove long parameter. It is included in data as radar_longitude
  • Remove height parameter. It is included in data as radar_height
  • Remove wavelength parameter. It is included in data as radar_wavelength
  • Allow to read a list of file paths, rather than single file. Those files will be combined.
  • Add readr as dependency
  • Distinguish between NA and NaN (see data read with read_stdout does not distinguish between NA and NaN (nodata and undetect) #40)
@peterdesmet peterdesmet self-assigned this Mar 10, 2023
@peterdesmet peterdesmet changed the title Adapt read_vpts()and VPTS object to VPTS CSV format Adapt read_vpts()and vpts object to VPTS CSV format Mar 10, 2023
@peterdesmet peterdesmet added the VPTS CSV Related to VPTS CSV format label Mar 10, 2023
@peterdesmet peterdesmet mentioned this issue May 29, 2023
9 tasks
@adokter adokter added this to the 1.0.0 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPTS CSV Related to VPTS CSV format
Projects
None yet
Development

No branches or pull requests

2 participants