Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtool::test() automatically deletes snapshots #465

Open
CeciliaNilsson709 opened this issue Jun 23, 2021 · 2 comments
Open

devtool::test() automatically deletes snapshots #465

CeciliaNilsson709 opened this issue Jun 23, 2021 · 2 comments
Labels
GA GitHub Actions (automated tests)
Milestone

Comments

@CeciliaNilsson709
Copy link
Collaborator

When running devtools::test() the snapshots from the plot tests are automatically deleted each time, causing the tests to always pass since there is no previous snapshot to compare too. This does not happen when testing just the test files individually or when running devtools::check(). It seems to be a known issue but the fix there does not seem to work for our case (yet). I'll keep an eye on it.

@peterdesmet peterdesmet added the GA GitHub Actions (automated tests) label Jun 26, 2021
@adokter adokter added this to the 0.7.0 milestone Apr 29, 2022
@adokter adokter modified the milestones: 1.0.0, 1.1.0 Aug 31, 2022
@jonekeat
Copy link

I also encounter same issue in my private repo, can @lionel- help us to investigate? Or please let me know if anything I could help with

The testthat package is amazing for unit tests, it is an important package for R community

@lionel-
Copy link

lionel- commented Mar 14, 2024

I don't really have bandwidth to help investigate this currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GA GitHub Actions (automated tests)
Projects
None yet
Development

No branches or pull requests

5 participants