Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with @types/react@19 #6388

Closed
SimenB opened this issue May 15, 2024 · 2 comments
Closed

Not compatible with @types/react@19 #6388

SimenB opened this issue May 15, 2024 · 2 comments

Comments

@SimenB
Copy link

SimenB commented May 15, 2024

Provide a general summary of the issue here

Following the instructions in the upgrade blog post gives errors from React Aria.

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-typescript-types

node_modules/@react-aria/textfield/dist/types.d.ts:2:10 - error TS2305: Module '"react"' has no exported member 'DOMFactory'.

2 import { DOMFactory, HTMLAttributes, LabelHTMLAttributes, ReactDOM, RefObject } from "react";
           ~~~~~~~~~~

node_modules/@react-aria/textfield/dist/types.d.ts:2:59 - error TS2305: Module '"react"' has no exported member 'ReactDOM'.

2 import { DOMFactory, HTMLAttributes, LabelHTMLAttributes, ReactDOM, RefObject } from "react";

🤔 Expected Behavior?

No TypeScript error

😯 Current Behavior

Errors! 😧

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

I can put one together if you really need it, but it's just imports in your code that needs to be updated.

import {
ChangeEvent,
DOMFactory,
HTMLAttributes,
LabelHTMLAttributes,
ReactDOM,
RefObject,
useEffect
} from 'react';

Version

react-aria-components@1.2.0

What browsers are you seeing the problem on?

Other

If other, please specify.

TypeScript error

What operating system are you using?

macOS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@reidbarber
Copy link
Member

Related #6276

@SimenB
Copy link
Author

SimenB commented May 15, 2024

Ah, right. That's probably a better issue to track. Thanks!

@SimenB SimenB closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants