New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryGet trait (Get() with default value) #166

Open

koraa opened this issue Mar 11, 2021 · 0 comments

Labels

breaking-change enhancement

Contributor

koraa commented Mar 11, 2021 •

edited

Rename the Get trait to TryGet; the signature should be tryGet(key, default).
We can derive from this:

const get = (c, k) => {
  const none = Symbol();
  const r = tryGet(c, k, none);
  assert(r !== none, "No such element");
  return r;
};

const has = (c, k) => {
  const none = Symbol();
  return tryGet(c, k, none) !== none;
}

Edit: This is a breaking change.

The text was updated successfully, but these errors were encountered:

koraa added the enhancement label

koraa added the breaking-change label

koraa changed the title ~~Get should take a default value~~ TryGet trait (Get() with default value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment