Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add constraint: for Submodel with kind=Instance Property/value and MultiLanguageProperty shall be defined. #398

Open
BirgitBoss opened this issue Apr 10, 2024 · 1 comment
Labels
requires workstream approval strategic decision in spec team needed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@BirgitBoss
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Up to now Property/value and Property/valueId (and similar for MultiLangaugeProperty) are both optional.
The reasons:
a) for Submodel TEmplate they do not exist
b) it is possible to either have a value or a valueId: in both cases a value would be defined

For the Value-Only-Serialization this leads to problems because it cannot be expected that properties do have a value.

There is one constraints for value and valueId:

Constraint AASd-007: If both the Property/value and the Property/valueId are present, the value of Property/value needs to be identical to the value of the referenced coded value in Property/valueId.

and

Constraint AASd-012: if both the MultiLanguageProperty/value and the MultiLanguageProperty/valueId are present, the meaning must be the same for each string in a specific language, as specified in MultiLanguageProperty/valueId.

Proposal:

  • Add Constraints:

For of Property within a Submodel with kind=Instance Property/value shall be defined.

For of MultiLanguageProperty within a Submodel with kind=Instance MultiLanguageProperty/value shall be defined.

Since the introduction of these constraints would not be backwards-comptible, we can first just request "should"

For of Property within a Submodel with kind=Instance Property/value should be defined.
and add a note: In future releases this constraints be mandatory to be fulfilled.

For of MultiLanguageProperty within a Submodel with kind=Instance MultiLanguageProperty/value should be defined.
and add a note: In future releases this constraints be mandatory to be fulfilled.

@mjacoby
Copy link

mjacoby commented Apr 11, 2024

What exactly does shall be defined mean here? Is null an acceptable value or e.g. in case of an integer property, must the value be a valid integer?

@BirgitBoss BirgitBoss added specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally requires workstream approval strategic decision in spec team needed labels Apr 12, 2024
@BirgitBoss BirgitBoss added this to the V3.1 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires workstream approval strategic decision in spec team needed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

No branches or pull requests

2 participants