File name not properly checked against XSS #1116

Admidio · Oct 20, 2021 · 01a83d4 · 01a83d4
1 parent 6b3820a
commit 01a83d4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/adm_program/system/bootstrap/function.php b/adm_program/system/bootstrap/function.php
@@ -392,7 +392,6 @@ function admFuncVariableIsValid(array $array, $variableName, $datatype, array $o
             {
                 if ($value !== '')
                 {
-                    $value = StringUtils::strStripTags(urldecode($value));
                     StringUtils::strIsValidFileName($value, false);
                 }
             }

diff --git a/adm_program/system/classes/StringUtils.php b/adm_program/system/classes/StringUtils.php
@@ -239,7 +239,7 @@ public static function strIsValidFileName($filename, $checkExtension = true)
             (!self::strValidCharacters($filename, 'folder') && !$checkExtension)
         )
         {
-            throw new AdmException('SYS_FILENAME_INVALID', array($filename));
+            throw new AdmException('SYS_FILENAME_INVALID', array(StringUtils::strStripTags($filename)));
         }
 
         if ($checkExtension)