Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window (Scrollable) #5

Open
ModeAxe opened this issue Dec 25, 2022 · 2 comments
Open

Window (Scrollable) #5

ModeAxe opened this issue Dec 25, 2022 · 2 comments
Assignees

Comments

@ModeAxe
Copy link
Contributor

ModeAxe commented Dec 25, 2022

Inherits default window but adds functionality to scroll.

See (https://www.figma.com/file/GEu7MTYyOOwK6ivSoPVyak?node-id=0:1&comments-enabled=1&viewer=1)

@ethmth
Copy link
Member

ethmth commented Jan 15, 2023

Hi this might be a silly question but is there any more specific description of this functionality? To me it seems like this means that within each desktop window, you can scroll if the content exceeds the window height. It seems like this functionality is already implemented (I don't think I did anything special to make it this way, it just seems like it by default). If this is not what it means or I'm supposed to do something else, I'd be happy to! Just please let me know.

@ModeAxe
Copy link
Contributor Author

ModeAxe commented Jan 15, 2023

Yeah, the description here is a bit unclear. Default window is supposed change it’s height to fit content and this one is supposed to have a fixed height and let users scroll. I believe your test window is already an example of this. One of the reasons this is a separate work item is because the styling of the scroll bar needs to change to match the design document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants