Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncompatible version of addok-csv 1.1.0 with current addok 1.1.1 and falcon 3.1.1 #804

Open
frodrigo opened this issue Oct 25, 2023 · 1 comment

Comments

@frodrigo
Copy link
Contributor

Using both last version of addok-csv 1.1.0 with addok 1.1.1 fails on CVS upload with {"title": "Malformed multipart/form-data request media", "description": "unexpected form structure"}.
Using the falcon version from requirements.txt (3.1.1).

After digging into the code is related on how addok-csv try to manually parse multi-part. The change comes from this commit addok/addok-csv@7957042

The new code try to parse before the stream was consumed. But it is already empty.
https://github.com/addok/addok-csv/blob/master/addok_csv/__init__.py#L149

Fall back to addok-csv 1.0.1 works.

@jdesboeufs
Copy link
Member

Hello,

I confirm addok-csv 1.1.0 is currently broken.
We also have #734.

In production for adresse.data.gouv.fr and the upcoming Geoplateforme geocoder we use https://github.com/livingdata-co/addok-server for CSV capabilities.

If you want to work on a bugfix, you're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants