Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content extraction failure on dozens of related sites #569

Closed
praveng opened this issue Apr 22, 2024 · 4 comments · Fixed by #571
Closed

Content extraction failure on dozens of related sites #569

praveng opened this issue Apr 22, 2024 · 4 comments · Fixed by #571
Labels
bug Something isn't working

Comments

@praveng
Copy link

praveng commented Apr 22, 2024

The failure is consistent across all articles on said sites; examples:

https://www.kiss1023.ca/2024/04/17/beyonce-is-bringing-her-fans-of-colour-to-country-music-will-they-be-welcomed-in/
https://www.kissottawa.com/2024/04/22/harmony-in-action-pop-stars-making-a-difference-for-the-environment/
https://www.country600.com/2024/04/22/embrace-the-earth-10-meaningful-activities-to-celebrate-earth-day/
https://www.chymfm.com/2024/04/22/fans-want-kelly-clarkson-to-be-a-disney-princess-voice-after-her-latest-kellyoke-pick/

And dozens more related sites.

Trafilatura seems to pick up the cookie consent text instead of the article text. For reference, goose3 does not have this issue. I'd appreciate any input on what's causing this.

Thanks

@adbar adbar added the bug Something isn't working label Apr 22, 2024
@adbar
Copy link
Owner

adbar commented Apr 22, 2024

Hi @praveng, thanks for your feedback, there is indeed a problem here. An aside element is removed during cleaning although it contains the main text, which thus cannot be retrieved afterwards.

I am not sure why this happens, maybe a parsing or cleaning issue. I started drafting a workaround in #571.

@praveng
Copy link
Author

praveng commented Apr 22, 2024

Thanks for the quick response! Please let me know if any action is needed on my part.

@adbar adbar linked a pull request Apr 24, 2024 that will close this issue
@adbar
Copy link
Owner

adbar commented Apr 24, 2024

The new logic slows things down a bit so I implemented it for the recall preset only (for now). You'd have to use it for the changes to take effect.

@praveng
Copy link
Author

praveng commented Apr 24, 2024

Nice one thanks! It is unteresting that including this tag would introduce a slowdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants