Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StoreKit 2 Product to AdaptyPaywallProduct #72

Open
RobertDresler opened this issue Feb 1, 2024 · 3 comments
Open

Add StoreKit 2 Product to AdaptyPaywallProduct #72

RobertDresler opened this issue Feb 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@RobertDresler
Copy link

RobertDresler commented Feb 1, 2024

Currently there is just SKProduct in AdaptyPaywallProduct . We want to use StoreKit 2 Product instead. I checked that there is already logic (fetchSK2Products and fetchSK2ProductsInSameOrder methods) for fetching and caching StoreKit 2 Products, so is it possible to add it to AdaptyPaywallProduct?

@RobertDresler
Copy link
Author

RobertDresler commented Feb 1, 2024

I created PR implementing my solution (#73). Maybe it would be better to fetch products from both StoreKit versions simultaneously.

@x401om
Copy link
Contributor

x401om commented Feb 12, 2024

Hey @RobertDresler!

Apologies for the delayed response.

Thanks a lot for the issue and the PR. We've taken a good look at what you're suggesting, but unfortunately, we can't merge your PR at the moment. The thing is, the proposed solution might lead to very slow performance of functions since requests to SK1 and SK2 could take a significant amount of time.

If you keep an eye on our updates, you'll see that we're gradually adding support for Store Kit 2 features as needed. However, our main purchase flow still operates through Store Kit 1. I suppose that in the foreseeable future, we might fully transition to the new system, but that would require some pretty serious architectural overhauls within our SDK.

Nevertheless, could you describe why you need access to SK2 product? What's lacking in the existing fields?

@RobertDresler
Copy link
Author

@x401om the thing is, we have custom designed paywalls inside our app and we need to format prices and StoreKit 2 just offers much better API for this. I think there should be way to offer working with modern StoreKit 2 Products. There should be at least way to get StoreKit 2 Products for those, who wants it, e.g. by setting StoreKit2Usage.

@x401om x401om added the enhancement New feature or request label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants