Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to streaming_extractor_music in PATH if it exists #23

Open
Kernald opened this issue Oct 20, 2022 · 3 comments
Open

Fall back to streaming_extractor_music in PATH if it exists #23

Kernald opened this issue Oct 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Kernald
Copy link

Kernald commented Oct 20, 2022

Use case

streaming_extractor_music already present in $PATH - this simplifies the configuration slightly

Solution

If the configuration key isn't set and the binary is in $PATH, silently use it rather than failing. Otherwise, still fail as currently.

@JOJ0
Copy link
Collaborator

JOJ0 commented Oct 20, 2022

Please post an example on how the config would look like with your proposed feature.

@JOJ0
Copy link
Collaborator

JOJ0 commented Oct 21, 2022

@Kernald let me rephrase why it's not entirely clear to me what your feature request is: Are you talking about the stream extractor binary only ooor you mean that we would potentially find svm models as well in that place?

@Kernald
Copy link
Author

Kernald commented Oct 23, 2022

I was just referring to the binary, as any folder in the $PATH should be a pretty standard location to store those binaries. As far as I know, there's no such standard location for the SVM models.

The reason I opened this issue is that I had the extractor binary in a folder in my $PATH, got an error about the binary being not found and was quite surprised, it's more about expected behaviour than simplifying the configuration file I guess.

@adamjakab adamjakab added the enhancement New feature or request label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants