Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Type definitions for sync API #10

Open
voodoo11 opened this issue Nov 30, 2018 · 5 comments
Open

Type definitions for sync API #10

voodoo11 opened this issue Nov 30, 2018 · 5 comments

Comments

@voodoo11
Copy link

Hi,
Thanks for great CSV parsing library!

Any chances you could add also Typescript type definitions to sync version? (sync.d.ts file)

@wdavidw
Copy link
Member

wdavidw commented Nov 30, 2018

Of course, would you have time to contribute it? I'm overbooked at the moment. You can look at the csv-parse/lib/sync.d.ts for inspiration.

@maxfriedmann
Copy link

I think this issue is partly done already, at least I can import parse, transform and stringify via ES6 imports in csv/lib/sync.

Any reason why //import * as generate from "csv-generate/lib/sync"; is commented out?

@wdavidw
Copy link
Member

wdavidw commented Apr 1, 2020

Where did you find the sync declaration? Look at the lib folder, I can't find any reference to the commented import statement.

@maxfriedmann
Copy link

in the csv/lib/sync.d.ts, am in the wrong repo here I guess?

image

@wdavidw
Copy link
Member

wdavidw commented Apr 1, 2020

the csv package is a sort of wrapper beind the 4 packages you see in your screenshot. generate is commented because it doesn't exists, thus this issue. The link sent above send you to the right location where the definition shall land.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants