Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for non-UTF-8 inputs #77

Open
lemire opened this issue Jan 20, 2023 · 3 comments
Open

Add support for non-UTF-8 inputs #77

lemire opened this issue Jan 20, 2023 · 3 comments
Labels
good first issue Good for newcomers specification issue

Comments

@lemire
Copy link
Member

lemire commented Jan 20, 2023

The entire code base assumes UTF-8. To support UTF-16, we simply need to transcode (easy!).
@lemire lemire linked a pull request Jan 22, 2023 that will close this issue
Sketch for UTF-16 support #95
Closed
@anonrig
Copy link
Member

anonrig commented Feb 9, 2023

We should research the use cases for adding non-UTF-8 input support before advancing/working on this.

@anonrig anonrig added the good first issue Good for newcomers label Feb 9, 2023
@lemire
Copy link
Member Author

lemire commented Feb 9, 2023

It is trivial to add a front-end transcoder to support any unicode encoding. But yeah... not much demand so far.

@anonrig
Copy link
Member

anonrig commented Feb 9, 2023

I wonder if there is any usage from non-browser environments for this. @jasnell any demand from cloudflare workers and/or node.js regarding this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers specification issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sketch for UTF-16 support ada-url/ada
2 participants
@lemire @anonrig