Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test coverage for encode_json for values smaller than 0x1f #516

Open
Uzlopak opened this issue Sep 26, 2023 · 3 comments
Open

Missing test coverage for encode_json for values smaller than 0x1f #516

Uzlopak opened this issue Sep 26, 2023 · 3 comments
Assignees

Comments

@Uzlopak
Copy link

Uzlopak commented Sep 26, 2023

What is the problem this feature will solve?

increases test coverage

What is the feature you are proposing to solve the problem?

I was investigating ada. I saw that you do 2 * c and was wondering if a bitshift makes a difference c << 1 but then I realized that if replace with just returning '0', then ctest --output-on-failure --test-dir build will pass all the tests. So there is missing test coverage.

I guess that the compiler will create the same bytecode for 2 * c and c << 1. But it would make sense to have test coverage.

What alternatives have you considered?

No response

@anonrig
Copy link
Member

anonrig commented Sep 27, 2023

Would you like to open a pull request for the missing test?

@Uzlopak
Copy link
Author

Uzlopak commented Sep 27, 2023

I have no clue where to put it :D

@anonrig
Copy link
Member

anonrig commented Oct 10, 2023

I have no clue where to put it :D

test/basic_tests.cpp works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants