Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kaminari] undefined method display_tag #5111

Closed
gingray opened this issue Jul 27, 2017 · 3 comments
Closed

[kaminari] undefined method display_tag #5111

gingray opened this issue Jul 27, 2017 · 3 comments

Comments

@gingray
Copy link

gingray commented Jul 27, 2017

Got the following issue

ActionView::Template::Error: undefined method `display_tag?' for #<Kaminari::Helpers::Paginator::PageProxy

If you're on Rails 5 and update to kaminari 0.17 you can probably get this error.

Solution:
This commit will solve the issue kaminari/kaminari@e95bb74

gem 'kaminari', github: 'kaminari/kaminari', ref: 'e95bb74'

I think it will be helpful for activeadmin users maybe we need to handle this on activeadmin side to explicitly include 'kaminari/core' but I'm not sure.

@javierjulio
Copy link
Member

javierjulio commented Jul 28, 2017

@gingray this isn't an issue that ActiveAdmin should fix since all you have to do is update Kaminari. They included a lot of fixes in the next version which was 1.0. Just run bundle update kaminari and you'll be good. Thanks!

@senid231
Copy link
Contributor

face it with rails 4.2.8 and activeadmin 1.1.0

every page with pagination raises same error for kaminari 0.15.0 and 0.17.0
for kaminari >= 1.0.0 looks fine

proposal: change kaminari dependency from kaminari (>= 0.15, < 2.0) to kaminari (>= 1.0.0, < 2.0)

@senid231
Copy link
Contributor

@Fivell what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants