Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-publish.yml requires version updates #2357

Open
zstewar1 opened this issue Mar 26, 2024 · 2 comments
Open

docker-publish.yml requires version updates #2357

zstewar1 opened this issue Mar 26, 2024 · 2 comments

Comments

@zstewar1
Copy link

The version of cosign in the docker-publish.yml workflow no longer works.

It causes a similar error to the one noted in sigstore/cosign#3614. For example, for one of my workflows, I get

main.go:74: error during command execution: signing [ghcr.io/zstewar1/zstewart.com:master@sha256:3c6911026f3c9ace2dbd52f78b0a51f917edb367c5e90eba74f515c2079c78a9]: getting signer: getting key from Fulcio: getting CTFE public keys: updating local metadata and targets: error updating to TUF remote mirror: invalid key

The version of cosign must be bumped to at least v2.2.0.

Additionally, docker-publish.yml still uses actions/checkout@v3 which produces warnings about the use of Node 16. This should be updated to use actions/checkout@v4.

TK221 added a commit to TK221/starter-workflows that referenced this issue Mar 26, 2024
@toffee-makes-things
Copy link

This, i ran a build and ran into this exact issue https://github.com/ren-makes-things/ProjectLighthouse/actions/runs/8474550225/job/23221133503

toffee-makes-things added a commit to toffee-makes-things/ProjectLighthouse that referenced this issue Mar 28, 2024
GitHub's own template is a little out of date, had to accommodate for this actions/starter-workflows#2357
github-merge-queue bot pushed a commit to LBPUnion/ProjectLighthouse that referenced this issue Mar 30, 2024
…gistry (#1004)

* Create docker-publish.yml

* Update docker-publish.yml

* Now this should work

GitHub's own template is a little out of date, had to accommodate for this actions/starter-workflows#2357

* updating to actions/checkout@v4

* Update docker-publish.yml

* Update do

Co-authored-by: sudokoko <koko@sudokoko.xyz>

* Update docker-publish.yml

Co-authored-by: sudokoko <koko@sudokoko.xyz>

* testing arm building

Co-authored-by: Zaprit <henry@vorax.org>

* an attempt to get this docker workflow to play nice with arm

* Revert "testing arm building"

This reverts commit a030b62.

* Revert "an attempt to get this docker workflow to play nice with arm"

This reverts commit 8faf3f4.

* Minor nitpicky things before merge

Committing these directly as to not bother you with another code review. Adds a nice-name to the job and renames "build" to "build-publish".

---------

Co-authored-by: sudokoko <koko@sudokoko.xyz>
Co-authored-by: Zaprit <henry@vorax.org>
kj800x added a commit to kj800x/timelapse-rs that referenced this issue Apr 2, 2024
kj800x added a commit to kj800x/weatherflow-tempest-influxdb-integration that referenced this issue Apr 2, 2024
kj800x added a commit to kj800x/metrics-dir-stat that referenced this issue Apr 2, 2024
kj800x added a commit to kj800x/heartbeat-rs that referenced this issue Apr 2, 2024
kj800x added a commit to kj800x/aws-cost-rs that referenced this issue Apr 2, 2024
@kj800x
Copy link

kj800x commented Apr 2, 2024

I can confirm that #2358 fixes this issue

TK221 added a commit to TK221/starter-workflows that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants