Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to use ComponentStory rather than Story for components with prop interfaces that use generics #428

Open
chasulin opened this issue Nov 21, 2022 · 3 comments
Labels
investigation Issues that need investigation and research ui-components A new component for ui-components package
Milestone

Comments

@chasulin
Copy link
Contributor

chasulin commented Nov 21, 2022

See 3rd bullet point in the "Notes for reviewer" section of this PR's description: #415

@chasulin chasulin added ui-components A new component for ui-components package investigation Issues that need investigation and research labels Nov 21, 2022
@mikelehen
Copy link
Contributor

@chasulin I know we discussed this and you did some StoryBook cleanup. Is there more to do, or can we consider this done?

@chasulin
Copy link
Contributor Author

chasulin commented Dec 12, 2022

@mikelehen this little part is unresolved and will require a bit more googling (its possible that you can't use ComponentStory with generics anyway, but again, itll take a little more googling on my part to confirm this if its the case).

but overall, our storybook is in a solid clean spot ✨✨. id de-prioritize this for now and put it in a backlog of some sort

@mikelehen mikelehen added this to the post-launch milestone Dec 12, 2022
@mikelehen
Copy link
Contributor

mikelehen commented Dec 12, 2022

@chasulin Thanks! I marked it post-launch. I am curious what the benefit would be to switch to ComponentStory though. If we are in a solid clean spot, maybe we can just close this and re-open if there's a need / reason to revisit? Else it seems like it could sit around in the backlog indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation Issues that need investigation and research ui-components A new component for ui-components package
Projects
None yet
Development

No branches or pull requests

2 participants