Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify "screenshot ready" logic in act-now-links-service and components / templates. #43

Open
mikelehen opened this issue Feb 6, 2023 · 0 comments
Milestone

Comments

@mikelehen
Copy link

mikelehen commented Feb 6, 2023

As discussed at standup, I think we could have two classes that we use in our components that asynchronously load data:

  • act-now-data-loading - used initially before data is loaded / ready.
  • act-now-data-loaded - used after data is rendered and it's safe to take a screenshot.

And the link service could wait until:

  1. At least one instance of act-now-data-loaded exists on the page.
  2. No instances of act-now-data-loading exists on the page.

Then you can just use our components in your share image, and it'll "just work" without any logic / mutation observers, etc...

@mikelehen mikelehen added this to the launch milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant