Don't impose to create secret

[armandleopold]

Hello,
You shouldn't impose user to create secrets before installing helm package. It goes against best practices of infrastructure as code where you define all your values in the hlem charts.
For exemple, we use Hashicorp Vault to pull our credentials directly in our values.yaml files before installing the chart.

By imposing us to create a secret file containing our secrets it goes against our policies.

datahub-helm/charts/prerequisites/values.yaml

Line 64 in 0c69e5f

existingSecret: mysql-secrets

datahub-helm/charts/prerequisites/values.yaml

Line 58 in 0c69e5f

existingPasswordSecret: neo4j-secrets

Please removes thoses lines as they can't be overriten.

[dexter-mh-lee]

Sorry about the late reply, we added these lines for easy spin up of required components. By uncommenting this, a lot of folks will have to modify values.yaml instead of using it as is.

You can unset a field by using this approach when installing
--set mysql.existingSecret=null

[dexter-mh-lee]

Reference https://banzaicloud.com/blog/creating-helm-charts-part-2/#removing-a-default-key

[armandleopold]

Hello Dexter, no you cannot from nested dependency Charts :
helm/helm#5184

[armandleopold]

I had to use a hack :

      # Bug Fix helm drop default datahub values
      sed -i 's/existingPasswordSecret: neo4j-secrets//' charts/datahub-prerequisites/values.yaml
      sed -i 's/existingSecret: mysql-secrets//' charts/datahub-prerequisites/values.yaml