grep: unrecognized option: P

[Anonym-tsk]

Grep in BusyBox doesn't support -P argument used in synology_dsm.sh

[Mon Apr 22 14:42:42 MSK 2024] Logging into 192.168.0.150:5001...
grep: unrecognized option: P
BusyBox v1.35.0 (2022-11-19 10:13:10 UTC) multi-call binary.

Usage: grep [-HhnlLoqvsrRiwFE] [-m N] [-A|B|C N] { PATTERN | -e PATTERN... | -f FILE... } [FILE]...

Search for PATTERN in FILEs (or stdin)

	-H	Add 'filename:' prefix
	-h	Do not add 'filename:' prefix
	-n	Add 'line_no:' prefix
	-l	Show only names of files that match
	-L	Show only names of files that don't match
	-c	Show only count of matching lines
	-o	Show only the matching part of line
	-q	Quiet. Return 0 if PATTERN is found, 1 otherwise
	-v	Select non-matching lines
	-s	Suppress open and read errors
	-r	Recurse
	-R	Recurse and dereference symlinks
	-i	Ignore case
	-w	Match whole words only
	-x	Match whole lines only
	-F	PATTERN is a literal (not regexp)
	-E	PATTERN is an extended regexp
	-m N	Match up to N times per file
	-A N	Print N lines of trailing context
	-B N	Print N lines of leading context
	-C N	Same as '-A N -B N'
	-e PTRN	Pattern to match
	-f FILE	Read pattern from file
[Mon Apr 22 14:42:42 MSK 2024] Unable to authenticate to https://192.168.0.150:5001, you may report the full log to the community.
[Mon Apr 22 14:42:42 MSK 2024] Error deploy for domain:***.net
[Mon Apr 22 14:42:42 MSK 2024] Deploy error.
[Mon Apr 22 14:42:42 MSK 2024] Error renew ***.net.
[Mon Apr 22 14:42:42 MSK 2024] Sending via: telegram
[Mon Apr 22 14:42:42 MSK 2024] telegram send success.
[Mon Apr 22 14:42:42 MSK 2024] telegram Success
[Mon Apr 22 14:42:42 MSK 2024] ===End cron===

Steps to reproduce

Latest docker container, Synology DSM deploy.
acme.sh --cron --home "/root/.acme.sh" --config-home "/acme.sh" --force

Debug log

acme.sh  --issue .....   --debug 2

[github-actions]

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

[thrytis]

This looks like the bug was introduced with this commit: feat: more user-friendly logic & error messages, specifically this line:

error_code=$(echo "$response" | grep '"error"' | grep -oP '(?<="code":)\d+')

on lines 202, 234, an 292.

Here is the section with the output with --debug 2

[Mon Apr 22 16:06:18 UTC 2024] SYNO_CERTIFICATE
[Mon Apr 22 16:06:18 UTC 2024] Getting API version...
[Mon Apr 22 16:06:18 UTC 2024] _base_url='https://msfrizzle.lair.spotdog.net:5001/'
[Mon Apr 22 16:06:18 UTC 2024] GET
[Mon Apr 22 16:06:18 UTC 2024] url='https://msfrizzle.lair.spotdog.net:5001/webapi/query.cgi?api=SYNO.API.Info&version=1&method=query&query=SYNO.API.Auth'
[Mon Apr 22 16:06:18 UTC 2024] timeout=
[Mon Apr 22 16:06:18 UTC 2024] _CURL='curl --silent --dump-header /[acme.sh/http.header](http://acme.sh/http.header)  -L  --trace-ascii /tmp/tmp.KRnZ6xdP4Z  -g '
[Mon Apr 22 16:06:18 UTC 2024] ret='0'
[Mon Apr 22 16:06:18 UTC 2024] Logging into msfrizzle.lair.spotdog.net:5001...
grep: unrecognized option: P
BusyBox v1.35.0 (2022-11-19 10:13:10 UTC) multi-call binary.

Usage: grep [-HhnlLoqvsrRiwFE] [-m N] [-A|B|C N] { PATTERN | -e PATTERN... | -f FILE... } [FILE]...

Search for PATTERN in FILEs (or stdin)

	-H	Add 'filename:' prefix
	-h	Do not add 'filename:' prefix
	-n	Add 'line_no:' prefix
	-l	Show only names of files that match
	-L	Show only names of files that don't match
	-c	Show only count of matching lines
	-o	Show only the matching part of line
	-q	Quiet. Return 0 if PATTERN is found, 1 otherwise
	-v	Select non-matching lines
	-s	Suppress open and read errors
	-r	Recurse
	-R	Recurse and dereference symlinks
	-i	Ignore case
	-w	Match whole words only
	-x	Match whole lines only
	-F	PATTERN is a literal (not regexp)
	-E	PATTERN is an extended regexp
	-m N	Match up to N times per file
	-A N	Print N lines of trailing context
	-B N	Print N lines of leading context
	-C N	Same as '-A N -B N'
	-e PTRN	Pattern to match
	-f FILE	Read pattern from file
[Mon Apr 22 16:06:18 UTC 2024] Session ID
[Mon Apr 22 16:06:18 UTC 2024] SynoToken
[Mon Apr 22 16:06:18 UTC 2024] Unable to authenticate to https://msfrizzle.lair.spotdog.net:5001/, you may report the full log to the community.

[alxwolf]

@scruel can you please check your latest commit! it basically broke acme.sh running docker (with busybox) when trying to deploy to DSM

[alxwolf]

@scruel

a working grep line (for busybox, without Perl syntax) should be

error_code=$(echo "$response" | grep -o '"code":[0-9]*' | grep -o '[0-9]*')

to replace code in lines mentioned by @thrytis

[scruel]

@alxwolf Thanks, fixed with your snippet.

[scruel]

acme.sh --upgrade -b dev

[Diluka]

acme.sh --upgrade -b dev

it's not working with docker

1. exec into container
2. ./entry.sh --upgrade -b dev
3. it says success
4. but when deploy, still error

[Neilpang]

synced to the master branch.
you can use the "latest" tag now.

[svasek]

synced to the master branch. you can use the "latest" tag now.

Hi @Neilpang,
I can confirm the latest docker image works like a charm.

Thak you!