Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky Hooks #11

Closed
2 tasks
nahumzs opened this issue Dec 20, 2018 · 4 comments
Closed
2 tasks

Husky Hooks #11

nahumzs opened this issue Dec 20, 2018 · 4 comments
Labels
Help Wanted Further information is requested, help is required Low Priority ↓ Research 📚 More information or research is needed

Comments

@nahumzs
Copy link
Contributor

nahumzs commented Dec 20, 2018

Estimation: unknown research

Husky hooks executed before committing your changes. We can use this to run linter and even testing to be sure that what we push into our repo has already passed most of the quality test.

https://github.com/typicode/husky

@nahumzs nahumzs added this to the Paprika milestone Dec 20, 2018
@alexzherdev
Copy link
Contributor

While I love the idea, I would consult with Ryan on this. An npm package installing git hooks is a potential security threat. Imagine someone hijacking this package like what happened with eslint-scope.

@nahumzs
Copy link
Contributor Author

nahumzs commented Dec 20, 2018

😵 Thank you to bring this on @alexzherdev 👏, do you think we might mitigate any of these issues if we set up 2FA for deploying once we move to open source? but totally worth double checking before moving with this initiative.

@nahumzs nahumzs removed this from the Paprika v1 April 01 milestone Jan 9, 2019
@nahumzs nahumzs added Help Wanted Further information is requested, help is required Low Priority ↓ Research 📚 More information or research is needed labels Jan 9, 2019
@nahumzs nahumzs changed the title Testing - Husky Hooks Husky Hooks Jan 11, 2019
@nahumzs
Copy link
Contributor Author

nahumzs commented Jan 29, 2019

This has been approved by Ryan and Alex, just keep in mind to add yarnpkg/yarn#5808 this before implementing husky hooks. 🎉

@nahumzs
Copy link
Contributor Author

nahumzs commented Feb 14, 2019

done by #34 and #35

@nahumzs nahumzs closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Further information is requested, help is required Low Priority ↓ Research 📚 More information or research is needed
Projects
None yet
Development

No branches or pull requests

2 participants