Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: filter pop-ups work different from the design in figma on mobile #1154

Open
mertkaya1033 opened this issue Feb 21, 2023 · 1 comment
Open

bug: filter pop-ups work different from the design in figma on mobile #1154

mertkaya1033 opened this issue Feb 21, 2023 · 1 comment
Assignees
@dopplerDistortion
Labels
android spotted on an android device approved pm approved this issue bug something is broken discussion we must discuss this further ios spotted on an iOS device

Comments

@mertkaya1033
Copy link
Contributor

Bug Definition

In current RC the filter does not adjust its size according to the viewport. In other words, the services filter was designed to act like the drawer in small devices. See figma.

** discord username: Sertcast#8543**

## Bug environment
rc.afetharita.com

Expected Behaviour

The implementation does not have to match the design one-to-one, however it is important for the filter to act like a drawer in small windows for better UX.

Screen shots

How it is right now:
RC

How it should look like: (will be a MUI select box rather than an accordion)
Expected
@mertkaya1033 mertkaya1033 added bug something is broken discussion we must discuss this further unchecked a PR or issue which is not yet checked waiting-test waiting for test approval labels Feb 21, 2023
@sercanerhan sercanerhan added the approved pm approved this issue label Feb 21, 2023
@usirin usirin assigned dopplerDistortion and unassigned usirin Feb 21, 2023
@usirin
Copy link
Contributor

usirin commented Feb 21, 2023

@dopplerDistortion assigned this to you as you have the best context. Can you please align with UX team on how we need to do this using MUI?

@usirin usirin removed the unchecked a PR or issue which is not yet checked label Feb 21, 2023
@usirin usirin changed the title bug: filter pop-ups are not responsive bug: filter pop-ups work different from the design in figma on mobile Feb 21, 2023
@usirin usirin added ios spotted on an iOS device android spotted on an android device and removed waiting-test waiting for test approval labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dopplerDistortion dopplerDistortion

Labels
android spotted on an android device approved pm approved this issue bug something is broken discussion we must discuss this further ios spotted on an iOS device
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dopplerDistortion @usirin @sercanerhan @mertkaya1033