Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering files using API is synchronous and renames the puma process #1332

Open
prioux opened this issue May 5, 2023 · 0 comments
Open
Labels
Admin Features or bugs related to administrative features API API issues or Swagger description Enhancement Priority: Normal

Comments

@prioux
Copy link
Member

prioux commented May 5, 2023

A bunch of API actions are designed to be performed by the controller code in synchronous mode, that is, they block until the operation finishes (successfully or not). This means the puma process associated with the controller action is blocked and unavailable from the pool of HTTP servers during that tijme.

Once such action is the 'register' action in the DataProvider controller. Not only does it block it also wrongly rename its process name while doing so (that is because in non API mode, it does fork in background, and in that case renaming the process is a useful feature for the sysadmin).

We should go through the entire set of API requests and for any of them that take a significant amount of time, make it always go in background, and provide a way for the API client to query the state of the operation.

@prioux prioux added Enhancement Priority: Normal API API issues or Swagger description Admin Features or bugs related to administrative features labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Features or bugs related to administrative features API API issues or Swagger description Enhancement Priority: Normal
Projects
None yet
Development

No branches or pull requests

1 participant