Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEG Browser : HED cosmetics to fix for release (important but minor) #9164

Closed
4 of 6 tasks
christinerogers opened this issue Mar 25, 2024 · 3 comments · Fixed by #9166
Closed
4 of 6 tasks

EEG Browser : HED cosmetics to fix for release (important but minor) #9164

christinerogers opened this issue Mar 25, 2024 · 3 comments · Fixed by #9166
Assignees
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Critical to release PR or issue is key for the release to which it has been assigned
Milestone

Comments

@christinerogers
Copy link
Contributor

christinerogers commented Mar 25, 2024

Module is working pretty well there are things that look broken / buggy (even if they're not technically) and should be smoothed over for the Release. (@jeffersoncasimir then for EEGNet too).
This is keeping in mind most LORIS datasets won't have HED tags on them.

in Dataset Tag Manager

  • When there are no EventValues in the whole dataset, don't display it in the Dataset Tag Manager. User can't do anything here, it looks like a bug. -- see screenshot 2.

  • Change Enter Description (coming soon) to n/a -- because it's wonky for a major release to say "coming soon" (like 2026 etc...)

Otherwise:

screenshot 1

Screen Shot 2024-03-25 at 4 47 05 PM

screenshot 2

Screen Shot 2024-03-25 at 4 54 42 PM

screenshot 3

Screen Shot 2024-03-25 at 4 56 46 PM
@christinerogers christinerogers added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Mar 25, 2024
@christinerogers christinerogers added this to the 26.0.0 milestone Mar 25, 2024
@christinerogers christinerogers added the Critical to release PR or issue is key for the release to which it has been assigned label Mar 25, 2024
@christinerogers christinerogers changed the title EEG Browser : HED cosmetics to fix for release EEG Browser : HED cosmetics to fix for release (important but minor) Mar 25, 2024
@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented Mar 26, 2024

All items have been addressed by #9166.

An issue was opened for the remaining actionable, as it is a significant feature. --> #9165

@christinerogers
Copy link
Contributor Author

christinerogers commented Mar 26, 2024

Adding one issue that is a just a typo so I've added the commit already to the #9166 branch :
literally the user needs to select a column name AND value to see/add HED tags - the message in italics needs a tweak
see screenshot -- they have selected column name as instructed and can't add a hed tag
Screen Shot 2024-03-26 at 12 12 00 PM

driusan pushed a commit that referenced this issue Mar 26, 2024
Fix minor GUI issues related to HED display.

Fixes #9164
@christinerogers
Copy link
Contributor Author

confirming these are resolved in round 2 testing.

Note that on many datasets the signal viewer plot isn't loading, alerted jefferson and Shen
https://test-dev-260.loris.ca/electrophysiology_browser/sessions/2161?outputType=raw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Critical to release PR or issue is key for the release to which it has been assigned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants