[media] fixes permissions. Allows media_read to download, renames "Delete" to "Hide". #9222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racostas
added
26.0.0-bugs
driusan
reviewed
Apr 26, 2024
| @@ -33,7 +33,7 @@ CREATE TABLE `permissions` ( | |||
| 'View/Create/Edit', | |||
| 'Create/Edit', | |||
| 'Edit/Upload', | |||
| 'Edit/Upload/Delete'), | |||
There was a problem hiding this comment.
I don't think we want to change this? This is the generic category used for all module permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Allows the
media_readpermission to actually download (see) the files. The permission in this descriptions statsMedia: View/Download Candidate Media Filesbut was not actually allowing to download (see) the documents.media_writewas substituted bymedia_readin the corresponding cases.The permission
Media: Edit/Upload/Delete Candidate Media Filesis renamed toMedia: Edit/Upload/Hide Candidate Media Filessince we are not able to Delete files but to Hide they.Testing instructions (if applicable)
media_readpermission.Media: Edit/Upload/Delete Candidate Media Filesis renamed toMedia: Edit/Upload/Hide Candidate Media Files.Link(s) to related issue(s)