Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Survey Accounts] Batch send surveys #8985

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Survey Accounts] Batch send surveys #8985

wants to merge 3 commits into from

Conversation

miladheshmati
Copy link
Contributor

@miladheshmati miladheshmati commented Nov 28, 2023 •
edited

Brief summary of changes

This PR changes the instrument select in the "add survey" section to a multi-select

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Go to Survey Accounts
  2. Click on Add survey
  3. The instrument selection should be a multi-select

Link(s) to related issue(s)

@miladheshmati miladheshmati added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Nov 28, 2023
@miladheshmati miladheshmati removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Nov 28, 2023
shonibare
shonibare approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@shonibare shonibare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan
Copy link
Collaborator

driusan commented Jan 11, 2024

@miladheshmati The tests on this are failing

@miladheshmati
Copy link
Contributor Author

@miladheshmati The tests on this are failing

@driusan I think it is related to the element change that we had to do in this PR. Should we modify the tests?

@driusan
Copy link
Collaborator

driusan commented Jan 16, 2024

@miladheshmati Yes, if required.

@driusan
Copy link
Collaborator

driusan commented Feb 6, 2024

@miladheshmati The tests on this are still failing and there's a file conflict in addsurvey.class.inc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shonibare shonibare shonibare approved these changes

Assignees

@shonibare shonibare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch send surveys
3 participants
@miladheshmati @driusan @shonibare